On 2021-01-27 15:59, Can Guo wrote:

On 2021-01-27 15:09, Avri Altman wrote:

quoted

quoted

Resumes the scsi device before accessing it.

Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
Signed-off-by: Asutosh Das <redacted>
Signed-off-by: Can Guo <redacted>
Signed-off-by: Bao D. Nguyen <redacted>

Following this patch, is it possible to revert commit 74e5e468b664d?

No, but this is a good finding... This change assumes
that the queue->queue_data is a scsi_device, which is
why we call scsi_auto_pm_get(). But for ufs_bsg's case,
queue->queue_data is a device...

If we call pm_runtime_get/put_sync(bcd->class_dev->parent) in
bsg_get/put_device(), commit 74e5e468b664d can be reverted.
This is just a rough idea.

Thanks,
Can Guo.

quoted

Thanks,
Avri