Re: [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed
From: Minwoo Im <hidden>
Date: 2021-01-05 10:13:04
Also in:
linux-fsdevel, lkml
From: Minwoo Im <hidden>
Date: 2021-01-05 10:13:04
Also in:
linux-fsdevel, lkml
Hello, On 21-01-05 08:50:09, Christoph Hellwig wrote:
On Tue, Jan 05, 2021 at 10:04:56AM +0900, Minwoo Im wrote:quoted
It was a point that I really would like to ask by RFC whether we can have backpointer to the gendisk from the request_queue. And I'd like to have it to simplify this routine and for future usages also.I think it is the right thing to do, at least mid-term, although I don't want to enforce the burden on you right now.quoted
I will restrict this one by checking GENHD_FL_UP flag from the gendisk for the next patch.quoted
Alternatively we could make this request_queue QUEUE* flag for now.As this patch rejects I/O from the block layer partition code, can we have this flag in gendisk rather than request_queue ?For now we can as the request_queue is required. I have some plans to clean up this area, but just using a request_queue flag for now is probably the simplest, even if it means more work for me later.
Please let me prepare the next quick fix for this issue with request_queue flag. Thanks!