Re: [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq
From: Daniel Wagner <hidden>
Date: 2020-12-08 12:42:37
From: Daniel Wagner <hidden>
Date: 2020-12-08 12:42:37
On Tue, Dec 08, 2020 at 12:49:36PM +0100, Sebastian Andrzej Siewior wrote:
On 2020-12-08 12:36:53 [+0100], Daniel Wagner wrote:quoted
Obvious in this configuration there are no remote completions (verified it).do you complete on a remote CPU if you limit the queues to one (this is untested of course)?
nvme0n1/ completed 11913011 remote 6718563 56.40% yes, but how is this relevant? I thought Jens complain was about the additional indirection via the softirq context - rq->q->mq_ops->complete(rq); + blk_mq_trigger_softirq(rq); and not the remote completion path. I can benchmark it out but I don't know if it's really helping in the discussion.