Thread (6 messages) 6 messages, 2 authors, 2020-12-02

Re: [PATCH] block: fix inflight statistics of part0

From: JeffleXu <jefflexu@linux.alibaba.com>
Date: 2020-12-02 08:50:11


On 12/2/20 4:29 PM, Christoph Hellwig wrote:
On Thu, Nov 26, 2020 at 05:48:33PM +0800, Jeffle Xu wrote:
quoted
The inflight of partition 0 doesn't include inflight IOs to all
sub-partitions, since currently mq calculates inflight of specific
partition by simply camparing the value of the partition pointer.

Thus the following case is possible:

$ cat /sys/block/vda/inflight
?? ?? ?? ??0 ?? ?? ?? ??0
$ cat /sys/block/vda/vda1/inflight
?? ?? ?? ??0 ?? ?? ??128

Partition 0 should be specially handled since it represents the whole
disk.

Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But can you resend with your information on the old kernels, and maybe
even with a Fixes tag?
Thanks, I will send a v2 version later.

-- 
Thanks,
Jeffle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help