Re: [PATCH] block: drop dead assignments in loop_init()
From: Julia Lawall <julia.lawall@inria.fr>
Date: 2020-12-11 20:00:41
Also in:
kernel-janitors, lkml
On Fri, 11 Dec 2020, Lukas Bulwahn wrote:
Commit 8410d38c2552 ("loop: use __register_blkdev to allocate devices on
demand") simplified loop_init(); so computing the range of the block region
is not required anymore and can be dropped.
Drop dead assignments in loop_init().
As compilers will detect these unneeded assignments and optimize this,
the resulting object code is identical before and after this change.
No functional change. No change in object code.It looks like some braces should be dropped too? julia
quoted hunk ↗ jump to hunk
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Christoph, please ack. Jens, please pick this minor non-urgent clean-up patch on your block -next tree on top of Christoph's commit above. drivers/block/loop.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/block/loop.c b/drivers/block/loop.c index d2ce1ddc192d..eed4bc5ef5c5 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c@@ -2304,7 +2304,6 @@ MODULE_ALIAS("devname:loop-control"); static int __init loop_init(void) { int i, nr; - unsigned long range; struct loop_device *lo; int err;@@ -2343,10 +2342,8 @@ static int __init loop_init(void) */ if (max_loop) { nr = max_loop; - range = max_loop << part_shift; } else { nr = CONFIG_BLK_DEV_LOOP_MIN_COUNT; - range = 1UL << MINORBITS; } err = misc_register(&loop_misc); --2.17.1