Thread (9 messages) 9 messages, 3 authors, 2020-12-02

Re: [PATCH 1/2] block: optimise for_each_bvec() advance

From: Christoph Hellwig <hch@infradead.org>
Date: 2020-11-26 10:01:05

On Tue, Nov 24, 2020 at 05:58:12PM +0000, Pavel Begunkov wrote:
Because of how for_each_bvec() works it never advances across multiple
entries at a time, so bvec_iter_advance() is an overkill. Add
specialised bvec_iter_advance_single() that is faster. It also handles
zero-len bvecs, so can kill bvec_iter_skip_zero_bvec().

   text    data     bss     dec     hex filename
before:
  23977     805       0   24782    60ce lib/iov_iter.o
before, bvec_iter_advance() w/o WARN_ONCE()
  22886     600       0   23486    5bbe ./lib/iov_iter.o
after:
  21862     600       0   22462    57be lib/iov_iter.o

Reviewed-by: Ming Lei <redacted>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help