Thread (10 messages) 10 messages, 2 authors, 2020-11-26

Re: [PATCH V2 blktests 3/5] nvmeof-mp/012, srp/012: fix the scheduler list

From: Yi Zhang <hidden>
Date: 2020-11-26 06:16:45
Also in: linux-nvme


On 11/26/20 11:59 AM, Bart Van Assche wrote:
On 11/24/20 11:32 PM, Yi Zhang wrote:
quoted
+# Get block dev scheduler list
+get_scheduler_list() {
+	local b=$1 p
+	p=/sys/block/"$b"/queue/scheduler
+	if [ -e "$p" ]; then
+		scheds=$(sed 's/[][]//g' /sys/block/"$b"/queue/scheduler)
+		echo "$scheds"
+	else
+		return 1
+	fi
+}
Can the echo statement and the 'scheds' assignment be left out? This is
what I have in mind:
Sure, will update with V3.
	sed 's/[][]//g' /sys/block/"$b"/queue/scheduler

Otherwise this patch looks good to me.

Thanks,

Bart.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help