Re: [PATCH V3] nvme: enable ro namespace for ZNS without append
From: Keith Busch <kbusch@kernel.org>
Date: 2020-11-10 22:09:46
Also in:
linux-nvme
On Tue, Nov 10, 2020 at 10:07:08PM +0100, javier@javigon.com wrote:
- if (id->nsattr & NVME_NS_ATTR_RO) + if (id->nsattr & NVME_NS_ATTR_RO || test_bit(NVME_NS_FORCE_RO, &ns->flags)) set_disk_ro(disk, true);
If the FORCE_RO flag is set, the disk is set to read-only. If that flag is later cleared, nothing clears the disk's read-only setting.
+ /* Refresh effects log page to check for changes on append support */ + status = nvme_get_effects_log(ns->ctrl, ns->head->ids.csi, &ns->head->effects);
That function just returns the cached log; no refresh occurs there.