Re: [PATCH 17/24] rbd: use set_capacity_and_notify
From: Ilya Dryomov <idryomov@gmail.com>
Date: 2020-11-11 09:55:51
Also in:
ceph-devel, dm-devel, linux-fsdevel, linux-nvme, linux-raid, linux-scsi, xen-devel
On Wed, Nov 11, 2020 at 9:27 AM Christoph Hellwig [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use set_capacity_and_notify to set the size of both the disk and block device. This also gets the uevent notifications for the resize for free. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com> --- drivers/block/rbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index f84128abade319..b7a194ffda55b4 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c@@ -4920,8 +4920,7 @@ static void rbd_dev_update_size(struct rbd_device *rbd_dev) !test_bit(RBD_DEV_FLAG_REMOVING, &rbd_dev->flags)) { size = (sector_t)rbd_dev->mapping.size / SECTOR_SIZE; dout("setting size to %llu sectors", (unsigned long long)size); - set_capacity(rbd_dev->disk, size); - revalidate_disk_size(rbd_dev->disk, true); + set_capacity_and_notify(rbd_dev->disk, size); } } --2.28.0
Hi Christoph,
The Acked-by is wrong here. I acked this patch (17/24, rbd), and Jack
acked the next one (18/24, rnbd).
Thanks,
Ilya