Re: [PATCH] blk: use REQ_OP_WRITE instead of hard code
From: Johannes Thumshirn <hidden>
Date: 2020-10-19 14:32:56
Also in:
lkml
On 19/10/2020 16:30, 苏辉 wrote:
Yeah, you are right, thanks for your explanation<br/><br/>Maybe we should define a MASK to do this?
Why? I personally find a '& 1' way more understandable than a REQ_OP_IS_WRITE_MASK or sth like that. The former I can just read, for the latter I would need to look up the definition to be able to understand the code.