Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software_resume
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2020-10-02 14:11:45
Also in:
cgroups, linux-pm, lkml
On Fri, Oct 2, 2020 at 8:50 AM Christoph Hellwig [off-list ref] wrote:
On Wed, Sep 30, 2020 at 05:45:27PM +0200, Rafael J. Wysocki wrote:quoted
On Fri, Sep 25, 2020 at 6:15 PM Christoph Hellwig [off-list ref] wrote:quoted
get_gendisk grabs a reference on the disk and file operation, so this code will leak both of them while having absolutely no use for the gendisk itself. This effectively reverts commit 2df83fa4bce421f ("PM / Hibernate: Use get_gendisk to verify partition if resume_file is integer format") Signed-off-by: Christoph Hellwig <hch@lst.de>Acked-by: Rafael J. Wysocki <redacted>Can you pick it up through the PM tree? The big rework in this area I have planned won't land before 5.11 anyway.
Will do, thanks!