Thread (4 messages) 4 messages, 3 authors, 2020-09-29

Re: [PATCH v2] blk-mq: call commit_rqs while list empty but error happen

From: Jens Axboe <axboe@kernel.dk>
Date: 2020-09-29 14:10:37

On 9/5/20 5:25 AM, yangerkun wrote:
Blk-mq should call commit_rqs once 'bd.last != true' and no more
request will come(so virtscsi can kick the virtqueue, e.g.). We already
do that in 'blk_mq_dispatch_rq_list/blk_mq_try_issue_list_directly' while
list not empty and 'queued > 0'. However, we can seen the same scene
once the last request in list call queue_rq and return error like
BLK_STS_IOERR which will not requeue the request, and lead that list
empty but need call commit_rqs too(Or the request for virtscsi will stay
timeout until other request kick virtqueue).

We found this problem by do fsstress test with offline/online virtscsi
device repeat quickly.
Applied, thanks.-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help