Thread (18 messages) 18 messages, 6 authors, 2020-07-27

Re: [PATCH 1/2] fs: fix kiocb ki_complete interface

From: Damien Le Moal <hidden>
Date: 2020-07-20 13:43:47
Also in: linux-fsdevel

On 2020/07/20 22:38, Christoph Hellwig wrote:
On Mon, Jul 20, 2020 at 10:21:17PM +0900, Johannes Thumshirn wrote:
quoted
From: Damien Le Moal <redacted>

The res and res2 fields of struct io_event are signed 64 bits values
(__s64 type). Allow the ki_complete method of struct kiocb to set 64
bits values in these fields by changin its interface from the long type
to long long.
Which doesn't help if the consumers can't deal with these values.
But that shouldn't even be required for using zone append anyway..
Not sure what you mean...

res2 is used to pass back to the user the written file offset, 64bits Bytes
value, for aio case (io_submit()/io_getevent()). The change does not break user
interface at all, no changes needed to any system call. The patch  just enables
passing that 64bit byte offset. The consumer of it would be the user
application, and yes, it does need to know what it is doing. But if it is using
zonefs, likely, the application knows.

-- 
Damien Le Moal
Western Digital Research
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help