Thread (5 messages) 5 messages, 3 authors, 2020-07-02

[PATCH] block: Set req quiet flag if bio is quiet

STALE2282d

From: Aleksei Marov <hidden>
Date: 2020-06-26 15:35:53
Subsystem: block layer, the rest · Maintainers: Jens Axboe, Linus Torvalds

The current behavior is that if bio flagged as BIO_QUIETis submitted to request based block device then the request
that wraps this bio in a queue is not quiet. RQF_FLAG is not
set anywhere. Hence, if errors happen we can see error
messages (e.g. in print_req_error) even though bio is quiet.
This patch fixes that by setting the flag in blk_rq_bio_prep.

Signed-off-by: Aleksei Marov <redacted>
---
 block/blk.h | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/block/blk.h b/block/blk.h
index b5d1f0f..04ca4e0 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -108,6 +108,9 @@ static inline void blk_rq_bio_prep(struct request
*rq, struct bio *bio,

        if (bio->bi_disk)
                rq->rq_disk = bio->bi_disk;
+
+       if (bio_flagged(bio, BIO_QUIET))
+               rq->rq_flags |= RQF_QUIET;
 }

 #ifdef CONFIG_BLK_DEV_INTEGRITY
-- 
1.8.3.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help