Re: [PATCH] blk-rq-qos: remove redundant finish_wait to rq_qos_wait.
From: Jens Axboe <axboe@kernel.dk>
Date: 2020-06-24 15:06:16
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
On 6/24/20 7:04 AM, Guo Xuenan wrote:
It is no need do finish_wait twice after acquiring inflight.
Seems cleaner to kill the redundant one, rather than adding a new one and removing another one. We end up with less code that way.
diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index 656460636ad3..18f3eab9f768 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c@@ -273,8 +273,6 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data, if (data.got_token) break; if (!has_sleeper && acquire_inflight_cb(rqw, private_data)) { - finish_wait(&rqw->wait, &data.wq); - /* * We raced with wbt_wake_function() getting a token, * which means we now have two. Put our local token
--
Jens Axboe