On Tue, Jun 23, 2020 at 09:20:35AM +0000, Niklas Cassel wrote:

On Tue, Jun 23, 2020 at 08:20:23AM +0200, Hannes Reinecke wrote:

quoted

On 6/22/20 6:25 PM, Keith Busch wrote:

quoted

From: Niklas Cassel <redacted>
-	if (ctrl->vs >= NVME_VS(1, 3, 0))
+	if (ctrl->vs >= NVME_VS(1, 3, 0) || nvme_multi_css(ctrl))
  		return nvme_identify_ns_descs(ctrl, nsid, ids);
  	return 0;
  }

Hmm? Are command sets even defined for something earlier than 1.3?

According to Keith, usually new features are not really tied to a
specific NVMe version.

Not really according to me; nvme just allows controllers to implement
features ratified after the initial version release.
 

So if someone implements/enables multiple command sets feature on
an older base spec of NVMe, we still want to support/allow that.

Right. We don't check the version to see if multi-command sets are
supported when we initially enable it, so we shouldn't need to check the
version later.