Thread (6 messages) 6 messages, 3 authors, 2020-07-16

Re: [PATCH 1/2] block: remove unnecessary ioc nested locking

From: Daniel Wagner <hidden>
Date: 2020-06-23 11:50:57
Also in: lkml

On Fri, Jun 19, 2020 at 05:23:17PM +0206, John Ogness wrote:
The legacy CFQ IO scheduler could call put_io_context() in its exit_icq()
elevator callback. This led to a lockdep warning, which was fixed in
commit d8c66c5d5924 ("block: fix lockdep warning on io_context release
put_io_context()") by using a nested subclass for the ioc spinlock.
However, with commit f382fb0bcef4 ("block: remove legacy IO schedulers")
the CFQ IO scheduler no longer exists.

The BFQ IO scheduler also implements the exit_icq() elevator callback but
does not call put_io_context().

The nested subclass for the ioc spinlock is no longer needed. Since it
existed as an exception and no longer applies, remove the nested subclass
usage.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
As far I can tell, looks good.

Reviewed-by: Daniel Wagner <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help