Re: [PATCH 3/3] io_uring: add support for zone-append

From: Jens Axboe <axboe@kernel.dk>
Date: 2020-06-19 15:52:06
Also in: linux-fsdevel, lkml

On 6/19/20 9:22 AM, Alexey Dobriyan wrote:

quoted

	uint64_t val = cqe->res; // assuming non-error here

	if (cqe->flags & IORING_CQE_F_ZONE_FOO)
		val |= (cqe->flags >> 16) << 32ULL;

Jens, ULL in shift doesn't do anything for widening the result.
You need

	val |= (uint64_t)(cqe->flags >> 16) << 32;

You're right of course, guess I should check my in-mail code a bit
better :-)

-- 
Jens Axboe