Re: [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err
From: Eric Biggers <ebiggers@kernel.org>
Date: 2020-05-26 23:20:53
Also in:
kernel-janitors, lkml
On Tue, May 26, 2020 at 11:49:02PM +0100, Colin King wrote:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted> The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <redacted> --- block/blk-crypto-fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index 74ab137ae3ba..6e49688a2d80 100644 --- a/block/blk-crypto-fallback.c +++ b/block/blk-crypto-fallback.c@@ -529,7 +529,7 @@ static bool blk_crypto_fallback_inited; static int blk_crypto_fallback_init(void) { int i; - int err = -ENOMEM; + int err; if (blk_crypto_fallback_inited) return 0;
Looks good, you can add: Reviewed-by: Eric Biggers [off-list ref] - Eric