On Fri, Mar 27, 2020 at 10:11:08AM +0000, Johannes Thumshirn wrote:

On 27/03/2020 09:34, Christoph Hellwig wrote:

quoted

-struct request_queue *blk_alloc_queue(gfp_t gfp_mask)
-{
-	return blk_alloc_queue_node(gfp_mask, NUMA_NO_NODE);
-}
-EXPORT_SYMBOL(blk_alloc_queue);

Why are you removing the non _node() variant? The memory allocation 
function for instance have this indirection as well and I don't think it 
simplifies a lot passing NUMA_NO_NODE in each block driver.

Because the two variants are rather pointless.  And this might get
more people to actually pass a useful node ID instead of copy and
pasting some old example code.