Re: [PATCH 2/9] block: mark part_in_flight and part_in_flight_rw static
From: Joe Perches <joe@perches.com>
Date: 2020-03-26 00:19:15
Also in:
lkml
On Wed, 2020-03-25 at 16:48 +0100, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig <hch@lst.de>
Some people still ask for some commit description, not just a sign-off line. I do think that's unnecessary though when, as here, the patch subject is descriptive and complete.
quoted hunk ↗ jump to hunk
diff --git a/block/genhd.c b/block/genhd.c
[]
quoted hunk ↗ jump to hunk
@@ -139,7 +139,8 @@ void part_dec_in_flight(struct request_queue *q, struct hd_struct *part, int rw) part_stat_local_dec(&part_to_disk(part)->part0, in_flight[rw]); } -unsigned int part_in_flight(struct request_queue *q, struct hd_struct *part) +static unsigned int part_in_flight(struct request_queue *q, + struct hd_struct *part)
genhd.c aligns multi-line arguments to open parenthesis, it'd be nicer to maintain that style.
quoted hunk ↗ jump to hunk
{ int cpu; unsigned int inflight;@@ -159,8 +160,8 @@ unsigned int part_in_flight(struct request_queue *q, struct hd_struct *part) return inflight; } -void part_in_flight_rw(struct request_queue *q, struct hd_struct *part, - unsigned int inflight[2]) +static void part_in_flight_rw(struct request_queue *q, struct hd_struct *part, + unsigned int inflight[2])
etc.