Re: [PATCH RFC v2 12/24] hpsa: use reserved commands
From: John Garry <hidden>
Date: 2020-03-17 09:38:25
Also in:
linux-scsi, lkml, virtualization
From: John Garry <hidden>
Date: 2020-03-17 09:38:25
Also in:
linux-scsi, lkml, virtualization
On 11/03/2020 08:10, Ming Lei wrote:
quoted
ands(struct ctlr_info *h)@@ -5803,6 +5803,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h) sh->max_lun = HPSA_MAX_LUN; sh->max_id = HPSA_MAX_LUN; sh->can_queue = h->nr_cmds - HPSA_NRESERVED_CMDS; + sh->nr_reserved_cmds = HPSA_NRESERVED_CMDS;Now .nr_reserved_cmds has been passed to blk-mq, you need to increase sh->can_queue to h->nr_cmds, because .can_queue is the whole queue depth (include the part of reserved tags), otherwise, IO tags will be decreased.
Sounds correct. Cheers, John
Not look into other drivers, I guess they need such change too. Thanks, Ming .