Thread (6 messages) 6 messages, 4 authors, 2020-01-30
STALE2356d
Revisions (3)
  1. v1 current
  2. v2 [diff vs current]
  3. v3 [diff vs current]

[PATCH blktests v1 2/2] nmve/018: Reword misleading error message

From: Daniel Wagner <hidden>
Date: 2020-01-28 08:44:48
Subsystem: the rest · Maintainer: Linus Torvalds

'nvme read' is expected to fail, though the error message "ERROR:
Successfully..." is misleading. Reword the error text to clarify the
real indent of the test and what failed.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Daniel Wagner <redacted>
---
 tests/nvme/018 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/nvme/018 b/tests/nvme/018
index d0f15db23538..aa9681b312f7 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -44,7 +44,7 @@ test() {
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
 	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
-		&& echo "ERROR: Successfully read out of device lba range"
+		&& echo "ERROR: nvme read was successful for out of range lba"
 
 	nvme disconnect -n "${subsys_name}"
 
-- 
2.16.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help