Thread (4 messages) 4 messages, 4 authors, 2020-01-08

Re: [resend v1 5/5] drivers/scsi/sd.c: Convert to use disk_set_capacity

From: James Bottomley <hidden>
Date: 2020-01-07 03:58:14
Also in: linux-nvme, lkml

On Mon, 2020-01-06 at 22:48 -0500, Martin K. Petersen wrote:
Balbir,
quoted
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5afb0046b12a..1a3be30b6b78 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3184,7 +3184,7 @@ static int sd_revalidate_disk(struct gendisk
*disk)
 
 	sdkp->first_scan = 0;
 
-	set_capacity(disk, logical_to_sectors(sdp, sdkp-
quoted
capacity));
+	disk_set_capacity(disk, logical_to_sectors(sdp, sdkp-
quoted
capacity));
 	sd_config_write_same(sdkp);
 	kfree(buffer);
We already emit an SDEV_EVT_CAPACITY_CHANGE_REPORTED event if device
capacity changes. However, this event does not automatically cause
revalidation.
Which I seem to remember was a deliberate choice: some change
capacities occur because the path goes passive and default values get
installed.

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help