On Wed, Jan 08, 2020 at 05:37:35AM -0800, Christoph Hellwig wrote:

quoted

+void bio_truncate(struct bio *bio, unsigned new_size)

This function really needs a kerneldoc or similar comment describing
what it does in detail.

OK, will do that.

quoted

+	if (bio_data_dir(bio) != READ)
+		goto exit;

This really should check the passed in op for REQ_OP_READ directly instead
of just the direction on the potentially not fully set up bio.

It has been addressed in:

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=block-5.5&id=802ca0381befe29ba0783e08e3369f9e87ef9d0d


Thanks,
Ming