Thread (7 messages) 7 messages, 4 authors, 2019-12-20

Re: [PATCH] xen/blkfront: Adjust indentation in xlvbd_alloc_gendisk

From: Roger Pau Monné <roger.pau@citrix.com>
Date: 2019-12-10 11:27:25
Also in: lkml, xen-devel

On Tue, Dec 10, 2019 at 08:15:22AM +0100, Jürgen Groß wrote:
On 09.12.19 21:14, Nathan Chancellor wrote:
quoted
Clang warns:

../drivers/block/xen-blkfront.c:1117:4: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
                 nr_parts = PARTS_PER_DISK;
                 ^
../drivers/block/xen-blkfront.c:1115:3: note: previous statement is here
                 if (err)
                 ^

This is because there is a space at the beginning of this line; remove
it so that the indentation is consistent according to the Linux kernel
coding style and clang no longer warns.

While we are here, the previous line has some trailing whitespace; clean
that up as well.

Fixes: c80a420995e7 ("xen-blkfront: handle Xen major numbers other than XENVBD")
Link: https://github.com/ClangBuiltLinux/linux/issues/791
Signed-off-by: Nathan Chancellor <redacted>
Reviewed-by: Juergen Gross <jgross@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help