Re: [PATCH] fs/iomap: remove redundant check in iomap_dio_rw()
From: Darrick J. Wong <hidden>
Date: 2019-10-29 16:15:18
Also in:
linux-fsdevel, linux-xfs
On Tue, Oct 29, 2019 at 05:40:47PM +0800, Joseph Qi wrote:
We've already check if it is READ iov_iter, no need check again. Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Applied to the iomap tree, thanks. Reviewed-by: Darrick J. Wong <redacted> --D
quoted hunk ↗ jump to hunk
--- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 1fc28c2..9712648 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c@@ -430,7 +430,7 @@ static void iomap_dio_bio_end_io(struct bio *bio) if (pos >= dio->i_size) goto out_free_dio; - if (iter_is_iovec(iter) && iov_iter_rw(iter) == READ) + if (iter_is_iovec(iter)) dio->flags |= IOMAP_DIO_DIRTY; } else { flags |= IOMAP_WRITE;-- 1.8.3.1