Re: [PATCH 1/1] blk-mq: reuse code in blk_mq_check_inflight*()
From: Christoph Hellwig <hch@infradead.org>
Date: 2019-09-30 08:33:31
Also in:
lkml
On Mon, Sep 30, 2019 at 11:27:32AM +0300, Pavel Begunkov (Silence) wrote:
From: Pavel Begunkov <asml.silence@gmail.com> 1. Reuse the same walker callback for both blk_mq_in_flight() and blk_mq_in_flight_rw(). 2. Store inflight counters immediately in struct mq_inflight. It's type-safer and removes extra indirection.
You really want to split this into two patches. Part 2 looks very sensible to me, but I don't really see how 1 is qn equivalent transformation right now. Splitting it out and writing a non-trivial changelog might help understanding it if you think it really is equivalent as-is.