Re: [PATCH 08/10] blkcg: implement blk-iocost
From: Paolo Valente <hidden>
Date: 2019-09-11 16:44:37
Also in:
cgroups, lkml
Il giorno 11 set 2019, alle ore 16:16, Tejun Heo [off-list ref] ha scritto: Hello, On Wed, Sep 11, 2019 at 10:18:53AM +0200, Paolo Valente wrote:quoted
quoted
The two being enabled at the same time doesn't make sense, so we can just switch over to bfq when bfq is selected as the iosched. I asked what Paolo wanted to do in terms of interface a couple times now but didn't get an answer and he posted a patch which makes the two controllers conflict, so.... Paolo, so it looks like you want to rename all bfq files to drop the bfq prefix, right?Yep, mainly because ... this is the solution you voted and you yourself proposed [1] :) [1] https://patchwork.kernel.org/patch/10988261/So, that was then. Since then the interface change has been published and userspace, at least some of them, already had to adjust. Now, I don't have any opinion on the matter and flipping again will cause inconveniences to some subset of users. It's your call.
Ok, then let's go for removing bfq prefix, as expected, e.g., by systemd community [1]. A few days ago I reposted a patch removing the prefix from all involved parameters [2], it should make all legacy software work again. [1] https://github.com/systemd/systemd/issues/7057 [2] https://lkml.org/lkml/2019/9/9/47
quoted
quoted
I can implement the switching if so.That would be perfect.Whichever way it gets decided, this is easy enough. I'll prep a patch.
Thank you for that too, Paolo
Thanks. -- tejun