Thread (3 messages) 3 messages, 2 authors, 2019-08-06

Re: [PATCH] block: Remove request_queue argument from blk_execute_rq_nowait

From: Christoph Hellwig <hch@lst.de>
Date: 2019-08-06 05:19:19
Also in: linux-nvme, linux-scsi, lkml, target-devel

On Mon, Aug 05, 2019 at 10:17:51PM -0300, Marcos Paulo de Souza wrote:
+void blk_execute_rq_nowait(struct gendisk *bd_disk, struct request *rq,
+			int at_head, rq_end_io_fn *done)
We store a ->rq_disk in struct request, so we should also not need
that.  And at_head should either become a bool, or be replaced with
a flags argument, ints used boolean are usually not a good idea.
quoted hunk ↗ jump to hunk
@@ -81,7 +80,7 @@ void blk_execute_rq(struct request_queue *q, struct gendisk *bd_disk,
And all the same argument changes that apply to blk_execute_rq_nowait
apply to blk_execute_rq as well.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help