Thread (6 messages) flat view 6 messages, 3 authors, 2019-06-18

Re: [PATCH] drbd: dynamically allocate shash descriptor

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2019-06-18 03:43:01
Also in: lkml

On Mon, Jun 17, 2019 at 10:58:58PM +0200, Arnd Bergmann wrote:
The warning is gone with this patch. Instead of 1280 bytes for drbd_receiver,
I now see 512 bytes, and 768 bytes for drbd_get_response, everything else is
under 160 bytes in this file.

However, with the call chain of

drbd_receiver
   conn_connect
       drbd_do_auth
             drbd_get_response

This still adds up to as much as before, so it only shuts up the
warning but does not reduce the maximum stack usage.
OK so it doesn't really reduce it.  Let's just go with your patch.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help