Re: [PATCH 4/9] blkcg: implement REQ_CGROUP_PUNT
From: Tejun Heo <tj@kernel.org>
Date: 2019-06-15 18:29:39
Also in:
linux-btrfs, lkml
From: Tejun Heo <tj@kernel.org>
Date: 2019-06-15 18:29:39
Also in:
linux-btrfs, lkml
Hello, On Sat, Jun 15, 2019 at 11:24:48AM -0700, Tejun Heo wrote:
When a shared kthread needs to issue a bio for a cgroup, doing so synchronously can lead to priority inversions as the kthread can be trapped waiting for that cgroup. This patch implements REQ_CGROUP_PUNT flag which makes submit_bio() punt the actual issuing to a dedicated per-blkcg work item to avoid such priority inversions. This will be used to fix priority inversions in btrfs compression and should be generally useful as we grow filesystem support for comprehensive IO control. Signed-off-by: Tejun Heo <tj@kernel.org> Reviewed-by: Josef Bacik <josef@toxicpanda.com> Cc: Chris Mason <clm@fb.com>
The blkcg patches, especially this one, need Jens's review. Jens, if you're okay with the changes, please let me know how you want them to be routed. Thanks. -- tejun