Thread (30 messages) 30 messages, 3 authors, 2019-03-25

Re: [PATCH v2 09/16] lightnvm: pblk: fix spin_unlock order

From: Matias Bjørling <hidden>
Date: 2019-03-25 11:09:50

On 3/22/19 3:48 PM, Igor Konopko wrote:
quoted hunk ↗ jump to hunk
In pblk_rb_tear_down_check() spin_unlock() functions are not
called in proper order. This patch fixes that.

Fixes: a4bd217 ("lightnvm: physical block device (pblk) target")
Signed-off-by: Igor Konopko <redacted>
Reviewed-by: Javier González <redacted>
Reviewed-by: Hans Holmberg <redacted>
---
  drivers/lightnvm/pblk-rb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 03c241b..3555014 100644
--- a/drivers/lightnvm/pblk-rb.c
+++ b/drivers/lightnvm/pblk-rb.c
@@ -799,8 +799,8 @@ int pblk_rb_tear_down_check(struct pblk_rb *rb)
  	}
  
  out:
-	spin_unlock(&rb->w_lock);
  	spin_unlock_irq(&rb->s_lock);
+	spin_unlock(&rb->w_lock);
  
  	return ret;
  }
Thanks, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help