Thread (69 messages) 69 messages, 5 authors, 2019-03-25

Re: [PATCH 08/18] lightnvm: pblk: fix spin_unlock order

From: Javier González <hidden>
Date: 2019-03-16 23:49:42

quoted hunk ↗ jump to hunk
On 14 Mar 2019, at 09.04, Igor Konopko [off-list ref] wrote:

In pblk_rb_tear_down_check() spin_unlock() functions are not
called in proper order. This patch fixes that.

Signed-off-by: Igor Konopko <redacted>
---
drivers/lightnvm/pblk-rb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 03c241b..3555014 100644
--- a/drivers/lightnvm/pblk-rb.c
+++ b/drivers/lightnvm/pblk-rb.c
@@ -799,8 +799,8 @@ int pblk_rb_tear_down_check(struct pblk_rb *rb)
	}

out:
-	spin_unlock(&rb->w_lock);
	spin_unlock_irq(&rb->s_lock);
+	spin_unlock(&rb->w_lock);

	return ret;
}
--
2.9.5
Ups. Thanks for fixing this...

Reviewed-by: Javier González <redacted>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help