Re: [PATCH v2 1/3] block: bio: kill BIO_SEG_VALID flag
From: Christoph Hellwig <hch@lst.de>
Date: 2019-03-22 14:01:46
Also in:
linux-fsdevel
From: Christoph Hellwig <hch@lst.de>
Date: 2019-03-22 14:01:46
Also in:
linux-fsdevel
+ if (bio->bi_phys_segments == -1) + bio->bi_phys_segments = 1; + else + bio->bi_phys_segments++;
Minor nitpickm but I'd kust write this as: if (bio->bi_phys_segments == -1) bio->bi_phys_segments = 0; bio->bi_phys_segments++; Otherwise this looks fine: Reviewed-by: Christoph Hellwig <hch@lst.de>