Thread (18 messages) 18 messages, 6 authors, 2019-03-25

Re: [PATCH v2 1/3] block: bio: kill BIO_SEG_VALID flag

From: Christoph Hellwig <hch@lst.de>
Date: 2019-03-22 14:01:46
Also in: linux-fsdevel

+	if (bio->bi_phys_segments == -1)
+		bio->bi_phys_segments = 1;
+	else
+		bio->bi_phys_segments++;
Minor nitpickm but I'd kust write this as:

	if (bio->bi_phys_segments == -1)
		bio->bi_phys_segments = 0;
	bio->bi_phys_segments++;

Otherwise this looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help