Thread (11 messages) 11 messages, 4 authors, 2019-02-07

Re: [PATCH 0/5 v6] Fix virtio-blk issue with SWIOTLB

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2019-02-05 20:52:51
Also in: linux-iommu, lkml

On Thu, Jan 31, 2019 at 05:33:58PM +0100, Joerg Roedel wrote:
Hi,

here is the next version of this patch-set. Previous
versions can be found here:

	V1: https://lore.kernel.org/lkml/20190110134433.15672-1-joro@8bytes.org/ (local)

	V2: https://lore.kernel.org/lkml/20190115132257.6426-1-joro@8bytes.org/ (local)

	V3: https://lore.kernel.org/lkml/20190123163049.24863-1-joro@8bytes.org/ (local)

	V4: https://lore.kernel.org/lkml/20190129084342.26030-1-joro@8bytes.org/ (local)

	V5: https://lore.kernel.org/lkml/20190130164007.26497-1-joro@8bytes.org/ (local)

The problem solved here is a limitation of the SWIOTLB implementation,
which does not support allocations larger than 256kb.  When the
virtio-blk driver tries to read/write a block larger than that, the
allocation of the dma-handle fails and an IO error is reported.

Changes to v5 are:

	- Changed patch 3 to uninline dma_max_mapping_size()
And this lead to problems reported by kbuild :(

BTW when you repost, can I ask you to pls include
the version in all patches? Both --subject-prefix
and -v flags to git format-patch will do this for you.

Please review.

Thanks,

	Joerg

Joerg Roedel (5):
  swiotlb: Introduce swiotlb_max_mapping_size()
  swiotlb: Add is_swiotlb_active() function
  dma: Introduce dma_max_mapping_size()
  virtio: Introduce virtio_max_dma_size()
  virtio-blk: Consider virtio_max_dma_size() for maximum segment size

 Documentation/DMA-API.txt    |  8 ++++++++
 drivers/block/virtio_blk.c   | 10 ++++++----
 drivers/virtio/virtio_ring.c | 11 +++++++++++
 include/linux/dma-mapping.h  |  8 ++++++++
 include/linux/swiotlb.h      | 11 +++++++++++
 include/linux/virtio.h       |  2 ++
 kernel/dma/direct.c          | 11 +++++++++++
 kernel/dma/mapping.c         | 14 ++++++++++++++
 kernel/dma/swiotlb.c         | 14 ++++++++++++++
 9 files changed, 85 insertions(+), 4 deletions(-)

-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help