Re: [PATCH] lightnvm: pblk: fix TRACE_INCLUDE_PATH
From: Hans Holmberg <hidden>
Date: 2019-01-25 08:02:06
Also in:
lkml
On Fri, Jan 25, 2019 at 8:35 AM Masahiro Yamada [off-list ref] wrote:
As the comment block in include/trace/define_trace.h says, TRACE_INCLUDE_PATH should be a relative path to the define_trace.h ../../drivers/lightnvm is the correct relative path. ../../../drivers/lightnvm is working by coincidence because the top Makefile adds -I$(srctree)/arch/$(SRCARCH)/include as a header search path, but we should not rely on it.
Nice catch, thanks! Reviewed-by: Hans Holmberg <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Masahiro Yamada <redacted> --- drivers/lightnvm/pblk-trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/lightnvm/pblk-trace.h b/drivers/lightnvm/pblk-trace.h index 679e5c45..9534503 100644 --- a/drivers/lightnvm/pblk-trace.h +++ b/drivers/lightnvm/pblk-trace.h@@ -139,7 +139,7 @@ TRACE_EVENT(pblk_state, /* This part must be outside protection */ #undef TRACE_INCLUDE_PATH -#define TRACE_INCLUDE_PATH ../../../drivers/lightnvm +#define TRACE_INCLUDE_PATH ../../drivers/lightnvm #undef TRACE_INCLUDE_FILE #define TRACE_INCLUDE_FILE pblk-trace #include <trace/define_trace.h> --2.7.4