Re: [PATCH v2 4/5] nvme-tcp: support separate queue maps for read and write
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-12-12 07:10:19
Also in:
linux-nvme
quoted
- queue->io_cpu = (qid == 0) ? 0 : qid - 1; + n = (qid ? qid - 1 : 0) % num_online_cpus(); + queue->io_cpu = cpumask_next_wrap(n - 1, cpu_online_mask, -1, false);Nitpick: can you use an if/else here? The ? : construct just looks like obsfucation. If nothing else pops up I can fix that up when applying.
Actually I noticed that the NVMF_OPT_WRITE_QUEUES was added to NVMF_ALLOWED_OPTS instead of locally to the supporting drivers... I'll send another quick revision tomorrow...