Re: [PATCH 1/2] blk-mq: Export iterating all tagged requests
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-12-04 17:38:34
Also in:
linux-nvme
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2018-12-04 17:38:34
Also in:
linux-nvme
quoted
quoted
Yes, I'm very much in favour of this, too. We always have this IMO slightly weird notion of stopping the queue, set some error flags in the driver, then _restarting_ the queue, just so that the driver then sees the error flag and terminates the requests. Which I always found quite counter-intuitive.What about requests that come in after the iteration runs? how are those terminated?If we've reached a dead state, I think you'd want to start a queue freeze before running the terminating iterator.
Its not necessarily dead, in fabrics we need to handle disconnections that last for a while before we are able to reconnect (for a variety of reasons) and we need a way to fail I/O for failover (or requeue, or block its up to the upper layer). Its less of a "last resort" action like in the pci case. Does this guarantee that after freeze+iter we won't get queued with any other request? If not then we still need to unfreeze and fail at queue_rq.