Re: [PATCH v5 1/2] lib: add crc64 calculation routines

From: Coly Li <hidden>
Date: 2018-12-29 04:13:46
Also in: linux-bcache, lkml

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 12/29/18 10:58 上午, NeilBrown wrote:

On Thu, Jul 26 2018, Andrew Morton wrote:

quoted

On Thu, 26 Jul 2018 13:33:51 +0800 Coly Li [off-list ref]
wrote:

quoted

This patch adds the re-write crc64 calculation routines for
Linux kernel. The CRC64 polynomial arithmetic follows ECMA-182
specification, inspired by CRC paper of Dr. Ross N. Williams 
(see http://www.ross.net/crc/download/crc_v3.txt) and other
public domain implementations.

Hi Coly and Andrew,

This patch breaks compilation if linux headers files are not
installed (reported at
https://github.com/gnubee-git/GnuBee_Docs/issues/75). Following
fixes it.

Thanks, NeilBrown

Hi Neil,

Thanks for the fix. I add by Acked-by.

Coly Li

From: NeilBrown <neil@brown.name> Subject: [PATCH] lib: don't
depend on linux headers being installed.

gen_crc64table requires linux include files to be installed in
/usr/include/linux.  This is a new requrement so hosts that could
previously build the kernel, now cannot.

gen_crc64table makes this requirement by including <linux/swab.h>, 
but nothing from that header is actaully used.

So remove the #include, so that the linux headers no longer need to
be installed.

Fixes: feba04fd2cf8 ("lib: add crc64 calculation routines") 
Signed-off-by: NeilBrown <neil@brown.name>

Acked-by: Coly Li <redacted>

quoted hunk ↗ jump to hunk

--- lib/gen_crc64table.c | 2 -- 1 file changed, 2 deletions(-)

diff --git a/lib/gen_crc64table.c b/lib/gen_crc64table.c index

9011926e4162..094b43aef8db 100644 --- a/lib/gen_crc64table.c +++
b/lib/gen_crc64table.c @@ -16,8 +16,6 @@ #include <inttypes.h> 
#include <stdio.h>

-#include <linux/swab.h> - #define CRC64_ECMA182_POLY
0x42F0E1EBA9EA3693ULL

static uint64_t crc64_table[256] = {0};

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help