Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues

block and nvme polling improvements V2 · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 01/13] block: move queues types to the block layer · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 01/13] block: move queues types to the block layer · Jens Axboe <axboe@fb.com> · 2018-11-29
Re: [PATCH 01/13] block: move queues types to the block layer · Christoph Hellwig <hch@lst.de> · 2018-11-30
Re: [PATCH 01/13] block: move queues types to the block layer · Jens Axboe <axboe@fb.com> · 2018-11-30
Re: [PATCH 01/13] block: move queues types to the block layer · Christoph Hellwig <hch@lst.de> · 2018-11-30
Re: [PATCH 01/13] block: move queues types to the block layer · Keith Busch <hidden> · 2018-11-29
Re: [PATCH 01/13] block: move queues types to the block layer · Jens Axboe <axboe@fb.com> · 2018-11-29
Re: [PATCH 01/13] block: move queues types to the block layer · Christoph Hellwig <hch@lst.de> · 2018-11-30
Re: [PATCH 01/13] block: move queues types to the block layer · Keith Busch <hidden> · 2018-11-30
Re: [PATCH 01/13] block: move queues types to the block layer · Jens Axboe <axboe@fb.com> · 2018-11-30
[PATCH 03/13] nvme-pci: cleanup SQ allocation a bit · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit · Keith Busch <hidden> · 2018-11-29
[PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled · Keith Busch <hidden> · 2018-11-29
[PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues · Keith Busch <hidden> · 2018-11-29
[PATCH 04/13] nvme-pci: only allow polling with separate poll queues · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues · Keith Busch <hidden> · 2018-11-29
Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues · Christoph Hellwig <hch@lst.de> · 2018-11-30
Re: [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues · Keith Busch <hidden> · 2018-11-30
[PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues · Christoph Hellwig <hch@lst.de> · 2018-11-29
Re: [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues · Keith Busch <hidden> · 2018-11-29
Re: [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues · Christoph Hellwig <hch@lst.de> · 2018-11-30
[PATCH 09/13] nvme-rdma: remove I/O polling support · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 10/13] nvme-mpath: remove I/O polling support · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 11/13] block: remove ->poll_fn · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 13/13] block: enable polling by default if a poll map is initalized · Christoph Hellwig <hch@lst.de> · 2018-11-29
[PATCH 12/13] block: only allow polling if a poll queue_map exists · Christoph Hellwig <hch@lst.de> · 2018-11-29

From: Keith Busch <hidden>
Date: 2018-11-29 20:40:37
Also in: linux-nvme

On Thu, Nov 29, 2018 at 08:13:03PM +0100, Christoph Hellwig wrote:

Pass the opcode for the delete SQ/CQ command as an argument instead of
the somewhat confusing pass loop.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Keith Busch <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help