Re: [PATCH 1/2] loop/006: Add test for setting partscan flag
From: Jan Kara <jack@suse.cz>
Date: 2018-10-24 21:42:57
On Tue 23-10-18 11:57:50, Omar Sandoval wrote:
quoted hunk ↗ jump to hunk
On Tue, Oct 23, 2018 at 12:05:12PM +0200, Jan Kara wrote:quoted
On Mon 22-10-18 15:52:55, Omar Sandoval wrote:quoted
On Thu, Oct 18, 2018 at 12:31:46PM +0200, Jan Kara wrote:quoted
Add test for setting partscan flag. Signed-off-by: Jan Kara <jack@suse.cz>Sorry I didn't notice this earlier, but loop/001 already does a partition rescan (via losetup -P). Does that cover this test case?Yes I know. But the partition rescanning on device creation has been handled properly while partition rescanning as a result of LOOP_SET_STATUS was buggy. That's why I've added this test.At least here, losetup -P does a LOOP_SET_STATUS: $ sudo strace -e ioctl losetup -f --show -P test.img ioctl(3, LOOP_CTL_GET_FREE) = 0 ioctl(4, LOOP_SET_FD, 3) = 0 ioctl(4, LOOP_SET_STATUS64, {lo_offset=0, lo_number=0, lo_flags=LO_FLAGS_PARTSCAN, lo_file_name="/home/osandov/test.img", ...}) = 0 /dev/loop0+++ exited with 0 +++
Right, my bad. Just discard this test then. Thanks for noticing this! Honza -- Jan Kara [off-list ref] SUSE Labs, CR