Thread (4 messages) 4 messages, 4 authors, 2018-10-29

Re: [PATCH V5] block: fix the DISCARD request merge

From: Jens Axboe <axboe@kernel.dk>
Date: 2018-10-29 15:33:25
Also in: lkml

On 10/27/18 5:52 AM, Jianchao Wang wrote:
There are two cases when handle DISCARD merge.
If max_discard_segments == 1, the bios/requests need to be contiguous
to merge. If max_discard_segments > 1, it takes every bio as a range
and different range needn't to be contiguous.

But now, attempt_merge screws this up. It always consider contiguity
for DISCARD for the case max_discard_segments > 1 and cannot merge
contiguous DISCARD for the case max_discard_segments == 1, because
rq_attempt_discard_merge always returns false in this case.
This patch fixes both of the two cases above.
Applied, thanks.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help