Re: [Xen-devel] [PATCH] xen/blkfront: avoid NULL blkfront_info dereference... | linux-block

(off-list ancestor, not in this archive)

On Thu, 2018-10-11 at 18:34 +0200, Roger Pau Monné wrote:

--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -2493,6 +2493,9 @@ static int blkfront_remove(struct
xenbus_device *xbdev)
 
 	dev_dbg(&xbdev->dev, "%s removed", xbdev->nodename);
 
+	if (!info)
+		goto out;
I don't see the point in adding the 'out' label. Can you just return
0
here?
of course, I will send a second version.
 
thanks for the review,

- Vasilis

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel