Thread (4 messages) 4 messages, 2 authors, 2018-10-16

RE: [PATCH] driver core: device: add BUS_ATTR_WO macro

From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: 2018-10-02 09:43:44
Also in: ceph-devel, linux-scsi, linuxppc-dev, lkml

quoted
Add BUS_ATTR_WO macro to make it easier to add attributes without
auditing the mode settings. Also, use the newly added macro where
appropriate.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++----
 drivers/block/rbd.c                      | 48 ++++++++++++++++--------=
--------
quoted
 drivers/scsi/fcoe/fcoe_sysfs.c           |  4 +--
 drivers/scsi/fcoe/fcoe_transport.c       | 10 +++----
 include/linux/device.h                   |  2 ++
 include/scsi/libfcoe.h                   |  8 +++---
 6 files changed, 43 insertions(+), 41 deletions(-)
=20
Nice!  This duplicates a lot of the work I did back in July but have not =
pushed out
very far due to the other things that ended up happening around that time=
:
	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/l=
og/?h=3Dbus_cleanup=20
=20
As the patch series seen at that link shows, you can do this in more plac=
es than
just what you did here.
=20
Either way, you should break this up into the individual patches, like I =
did or you
can take my patches if you want.  Getting the BUS_ATTR_WO() macro added i=
s
good to do now, and then you can go and hit up all of the different subsy=
stems
that should be converted over to it.
I can of course split my patch into individual ones and resubmit them, but =
as you already have the entire patch set ready, I feel like we can just pus=
h those. I looked through your changes and it seems like you covered all th=
e subsystems. Please let me know if there is something else I should do.

My intention here was to first add the _WO attribute so that afterwards I c=
an add a new bus attribute in the fsl-mc bus.

Ioana
=20
thanks,
=20
greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help