Thread (3 messages) 3 messages, 3 authors, 2018-09-30

Re: [PATCH -next] lightnvm: pblk: fix error handling of pblk_lines_init()

From: Hans Holmberg <hidden>
Date: 2018-09-26 12:41:15
Also in: kernel-janitors

On Wed, Sep 26, 2018 at 7:47 AM Wei Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
In the too many bad blocks error handling case, we should release all
the alloced resources instead direct return, otherwise it will cause
memory leak.

Fixes: 2deeefc02dff ("lightnvm: pblk: fail gracefully on line alloc. failure")
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/lightnvm/pblk-init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 537e98f..a26f4e6 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -1083,7 +1083,8 @@ static int pblk_lines_init(struct pblk *pblk)

        if (!nr_free_chks) {
                pblk_err(pblk, "too many bad blocks prevent for sane instance\n");
-               return -EINTR;
+               ret = -EINTR;
+               goto fail_free_lines;
        }

        pblk_set_provision(pblk, nr_free_chks);
Looks good to me.

Reviewed-by: Hans Holmberg <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help