Re: [PATCH v9 1/8] blk-mq: Document the functions that iterate over requests
From: Bart Van Assche <bvanassche@acm.org>
Date: 2018-09-20 15:30:41
From: Bart Van Assche <bvanassche@acm.org>
Date: 2018-09-20 15:30:41
On Thu, 2018-09-20 at 09:35 +0200, Johannes Thumshirn wrote:
On Wed, Sep 19, 2018 at 03:45:23PM -0700, Bart Van Assche wrote:quoted
+/* + * Call function @fn(@hctx, rq, @data, @reserved) for each request queued on + * @hctx that has been assigned a driver tag. @reserved indicates whether @bt + * is the breserved_tags member or the bitmap_tags member of struct + * blk_mq_tags. + */ static void bt_for_each(struct blk_mq_hw_ctx *hctx, struct sbitmap_queue *bt, busy_iter_fn *fn, void *data, bool reserved)One minor nit and only if you have to re-send the series, can you please also add the usual kernel-doc headers to the comments, i.e.:
OK, I will use the kernel-doc format.
Otherwise: Reviewed-by: Johannes Thumshirn <redacted>
Thanks! Bart.