On Wed, 2018-08-08 at 01:44 +0800, Ming Lei wrote:

t scsi_device *sdev, const unsigned char *cmd,

 	struct request *req;
 	struct scsi_request *rq;
 	int ret = DRIVER_ERROR << 24;
+	struct request_queue *q = sdev->host->admin�

8-q;

=20
-	req = blk_get_request(sdev->request_queue,
+	req = blk_get_request(q,
 			data_direction == DMA_TO_DEVICE ?
 			REQ_OP_SCSI_OUT : REQ_OP_SCSI_IN, BLK_=

-MQ_REQ_PREEMPT);

The above looks weird to me. Why are all RQF_PREEMPT requests sent to t=
he admin
queue instead of only RQF_PM requests?

scsi_device *sdev, const unsigned char *cmd,

 	req->cmd_flags |= flags;
 	req->rq_flags |= rq_flags | RQF_QUIET;=

-

=20
+	atomic_inc(&sdev->nr_admin_pending);

Why has a new counter been introduced to keep track of admin requests inste=
ad of
using q_usage_counter?

Thanks,

Bart.