Re: [PATCH 1/3] block: don't use bio->bi_vcnt to figure out segment number

[PATCH 0/3] block: fix mismatch of figuring out physical segment number · Ming Lei <hidden> · 2018-07-31
[PATCH 1/3] block: don't use bio->bi_vcnt to figure out segment number · Ming Lei <hidden> · 2018-07-31
Re: [PATCH 1/3] block: don't use bio->bi_vcnt to figure out segment number · Christoph Hellwig <hch@lst.de> · 2018-08-01
[PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE · Ming Lei <hidden> · 2018-07-31
Re: [PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE · Christoph Hellwig <hch@lst.de> · 2018-08-01
Re: [PATCH 2/3] block: kill QUEUE_FLAG_NO_SG_MERGE · Ming Lei <hidden> · 2018-08-01
[PATCH 3/3] block: kill BLK_MQ_F_SG_MERGE · Ming Lei <hidden> · 2018-07-31
Re: [PATCH 0/3] block: fix mismatch of figuring out physical segment number · Mike Snitzer <hidden> · 2018-07-31
Re: [PATCH 0/3] block: fix mismatch of figuring out physical segment number · Ming Lei <tom.leiming@gmail.com> · 2018-08-06

From: Christoph Hellwig <hch@lst.de>
Date: 2018-08-01 14:52:25

On Tue, Jul 31, 2018 at 06:49:12PM +0800, Ming Lei wrote:

It is wrong to use bio->bi_vcnt to figure out how many segments
there are in the bio even though CLONED flag isn't set on this bio,
because this bio may be splitted or advanced.

So always use bio_segments() in blk_recount_segments(), and it shouldn't
cause any performance loss now because the physical segment number is figured
out in blk_queue_split() and BIO_SEG_VALID is set meantime since
bdced438acd83ad83a6c ("block: setup bi_phys_segments after splitting").

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help