[PATCH v3 6/9] block: Warn if pm_runtime_get*() has not been called
From: Bart Van Assche <hidden>
Date: 2018-08-02 18:29:41
Subsystem:
block layer, the rest · Maintainers:
Jens Axboe, Linus Torvalds
Make it easier to determine from which code path a pm_runtime_get*() call is missing by issuing a warning if such a call is missing. Signed-off-by: Bart Van Assche <redacted> Cc: Christoph Hellwig <hch@lst.de> Cc: Jianchao Wang <redacted> Cc: Ming Lei <redacted> Cc: Alan Stern <stern@rowland.harvard.edu> Cc: Johannes Thumshirn <redacted> --- block/blk-pm.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/blk-pm.h b/block/blk-pm.h
index 226fe34c0df9..3978a3021958 100644
--- a/block/blk-pm.h
+++ b/block/blk-pm.h@@ -13,8 +13,10 @@ static inline void blk_pm_requeue_request(struct request *rq) static inline void blk_pm_add_request(struct request_queue *q, struct request *rq) { - if (q->dev && !(rq->rq_flags & RQF_PREEMPT) && - (q->rpm_status == RPM_SUSPENDED || q->rpm_status == RPM_SUSPENDING)) + if (!q->dev || (rq->rq_flags & RQF_PREEMPT)) + return; + WARN_ON_ONCE(atomic_read(&q->dev->power.usage_count) == 0); + if (q->rpm_status == RPM_SUSPENDED || q->rpm_status == RPM_SUSPENDING) pm_request_resume(q->dev); }
--
2.18.0